Skip to content

use synced aptly#50403

Draft
brycekahle wants to merge 2 commits intomainfrom
bryce.kahle/aptly-update
Draft

use synced aptly#50403
brycekahle wants to merge 2 commits intomainfrom
bryce.kahle/aptly-update

Conversation

@brycekahle
Copy link
Copy Markdown
Member

@brycekahle brycekahle commented May 5, 2026

What does this PR do?

Uses a synced version of github.com/DataDog/aptly that does not have the module renamed, so we use a replace directive in go.mod.

Motivation

Our renamed fork was pretty outdated. This will make it easier to keep synced with upstream.

Describe how you validated your changes

KMT tests.

Additional Notes

@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label May 5, 2026
@github-actions github-actions Bot added the medium review PR review might take time label May 5, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 5, 2026

Go Package Import Differences

Baseline: f8a86d4
Comparison: 97c3e12

binaryosarchchange
system-probelinuxamd64
+15, -7
+cloud.google.com/go/compute/metadata
-github.com/DataDog/aptly/aptly
-github.com/DataDog/aptly/database
-github.com/DataDog/aptly/deb
-github.com/DataDog/aptly/http
-github.com/DataDog/aptly/pgp
-github.com/DataDog/aptly/utils
+github.com/aptly-dev/aptly/aptly
+github.com/aptly-dev/aptly/database
+github.com/aptly-dev/aptly/deb
+github.com/aptly-dev/aptly/http
+github.com/aptly-dev/aptly/pgp
+github.com/aptly-dev/aptly/utils
-github.com/pborman/uuid
+github.com/saracen/walker
+golang.org/x/oauth2
+golang.org/x/oauth2/authhandler
+golang.org/x/oauth2/google
+golang.org/x/oauth2/google/externalaccount
+golang.org/x/oauth2/internal
+golang.org/x/oauth2/jws
+golang.org/x/oauth2/jwt
system-probelinuxarm64
+15, -7
+cloud.google.com/go/compute/metadata
-github.com/DataDog/aptly/aptly
-github.com/DataDog/aptly/database
-github.com/DataDog/aptly/deb
-github.com/DataDog/aptly/http
-github.com/DataDog/aptly/pgp
-github.com/DataDog/aptly/utils
+github.com/aptly-dev/aptly/aptly
+github.com/aptly-dev/aptly/database
+github.com/aptly-dev/aptly/deb
+github.com/aptly-dev/aptly/http
+github.com/aptly-dev/aptly/pgp
+github.com/aptly-dev/aptly/utils
-github.com/pborman/uuid
+github.com/saracen/walker
+golang.org/x/oauth2
+golang.org/x/oauth2/authhandler
+golang.org/x/oauth2/google
+golang.org/x/oauth2/google/externalaccount
+golang.org/x/oauth2/internal
+golang.org/x/oauth2/jws
+golang.org/x/oauth2/jwt

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 5, 2026

Files inventory check summary

File checks results against ancestor f8a86d4f:

Results for datadog-agent_7.80.0~devel.git.535.97c3e12.pipeline.111841341-1_amd64.deb:

No change detected

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1-2 Bot commented May 5, 2026

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 50.09% (-0.16%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 97c3e12 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented May 6, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: cb1bfe4d-89fe-4120-8e82-64f3e2858cd4

Baseline: c88f72e
Comparison: 97c3e12
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.65 [-0.34, +5.64] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.65 [-0.34, +5.64] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.81 [+0.60, +1.02] 1 Logs
quality_gate_metrics_logs memory utilization +0.49 [+0.24, +0.75] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.49 [+0.45, +0.52] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.35 [+0.25, +0.46] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.21 [+0.14, +0.27] 1 Logs
quality_gate_idle_all_features memory utilization +0.20 [+0.16, +0.24] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.16 [+0.06, +0.27] 1 Logs
quality_gate_idle memory utilization +0.08 [+0.03, +0.12] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.08 [-0.37, +0.52] 1 Logs
quality_gate_security_idle memory utilization +0.06 [-0.01, +0.13] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.06 [-0.12, +0.24] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.38, +0.43] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.08, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.14, +0.16] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.22, +0.20] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.22, +0.20] 1 Logs
otlp_ingest_metrics memory utilization -0.08 [-0.23, +0.07] 1 Logs
docker_containers_memory memory utilization -0.10 [-0.20, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.10 [-0.60, +0.40] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.12 [-0.36, +0.12] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.15 [-0.20, -0.10] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.21 [-0.37, -0.05] 1 Logs
ddot_metrics memory utilization -0.28 [-0.48, -0.09] 1 Logs
quality_gate_logs % cpu utilization -0.36 [-1.35, +0.63] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 521 ≥ 26
docker_containers_memory memory_usage 10/10 243.85MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 699 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.16GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.17GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 141.19MiB ≤ 147MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 474.21MiB ≤ 495MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 177.00MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 351.00 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 375.20MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 24.84 ≤ 40 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 292.40MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 54.86 ≤ 70 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 266.30MiB ≤ 320MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 20.56 ≤ 40 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 282.43MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 6, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor f8a86d4
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +229.32 KiB (0.03% increase) 742.270 → 742.494 → 750.310
agent_deb_amd64_fips +234.19 KiB (0.03% increase) 700.340 → 700.569 → 702.690
agent_rpm_amd64 +229.32 KiB (0.03% increase) 742.253 → 742.477 → 750.280
agent_rpm_amd64_fips +234.19 KiB (0.03% increase) 700.324 → 700.553 → 702.670
agent_rpm_arm64 +213.02 KiB (0.03% increase) 720.170 → 720.378 → 724.050
agent_rpm_arm64_fips +212.02 KiB (0.03% increase) 681.332 → 681.539 → 684.460
agent_suse_amd64 +229.32 KiB (0.03% increase) 742.253 → 742.477 → 750.280
agent_suse_amd64_fips +234.19 KiB (0.03% increase) 700.324 → 700.553 → 702.670
agent_suse_arm64 +213.02 KiB (0.03% increase) 720.170 → 720.378 → 724.050
agent_suse_arm64_fips +212.02 KiB (0.03% increase) 681.332 → 681.539 → 684.460
docker_agent_amd64 +229.31 KiB (0.03% increase) 802.512 → 802.736 → 805.870
docker_agent_arm64 +213.02 KiB (0.03% increase) 805.269 → 805.477 → 809.730
docker_agent_jmx_amd64 +229.32 KiB (0.02% increase) 993.432 → 993.656 → 996.590
docker_agent_jmx_arm64 +213.02 KiB (0.02% increase) 984.968 → 985.176 → 989.410
19 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_heroku_amd64 309.209 MiB
agent_msi 608.068 MiB
docker_cluster_agent_amd64 206.607 MiB
docker_cluster_agent_arm64 220.634 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_host_profiler_amd64 301.579 MiB
docker_host_profiler_arm64 313.054 MiB
docker_dogstatsd_amd64 39.492 MiB
docker_dogstatsd_arm64 37.690 MiB
dogstatsd_deb_amd64 30.145 MiB
dogstatsd_deb_arm64 28.275 MiB
dogstatsd_rpm_amd64 30.145 MiB
dogstatsd_suse_amd64 30.145 MiB
iot_agent_deb_amd64 44.470 MiB
iot_agent_deb_arm64 41.450 MiB
iot_agent_deb_armhf 42.186 MiB
iot_agent_rpm_amd64 44.470 MiB
iot_agent_suse_amd64 44.470 MiB

@brycekahle brycekahle added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels May 6, 2026
@brycekahle brycekahle force-pushed the bryce.kahle/aptly-update branch from a4c8776 to 97c3e12 Compare May 6, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed component/system-probe internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/ebpf-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant